LG-3756: Bump Node devDependencies to latest#4521
Merged
Conversation
**Why:** As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible.
aduth
commented
Dec 21, 2020
| excludeCredentials: [ | ||
| { | ||
| // encodes to 'credential123' | ||
| id: Buffer.from([114, 183, 157, 122, 123, 98, 106, 93, 118]).buffer, |
Contributor
Author
There was a problem hiding this comment.
Pretty sure this was always broken, since the buffer here is not actually "credential123", it's "credential12":
window.btoa(String.fromCharCode(...new Uint8Array([114, 183, 157, 122, 123, 98, 106, 93, 118])))
// "credential12"This is clearer anyways.
This became a failure in upgrading chai, likely related to release notes concerning deep equality revisions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a user, I want login.gov to not have unused or out of date apps, so that I can use the fastest and most secure app possible.
This only updates devDependencies, under the assumption that they are generally less risky. They are not immune to risk, given that some devDependencies are responsible for generating runtime code (e.g. Babel, Webpack, etc).
Using
ncu:Notable major version bumps:
@types/reactbrings TypeScript definitions in line with React 17 (see Upgrade React from 16.13.1 to 17.0.1 #4362).