Refactor async proofing data storage#4498
Merged
mitchellhenke merged 8 commits intomasterfrom Dec 9, 2020
Merged
Conversation
8a289a1 to
c3c7c2c
Compare
zachmargolis
reviewed
Dec 8, 2020
Contributor
zachmargolis
left a comment
There was a problem hiding this comment.
Just did a first pass, but looks good! Will try to review more closely in a bit
c727b48 to
44a5d6c
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
b4fce6f to
3d4d4a3
Compare
zachmargolis
approved these changes
Dec 9, 2020
Contributor
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the async proofing process would store the arguments used for the vendor proofing call as backgrounds jobs were intended to load inputs from Redis instead of figuring out how to have the background job store encrypt its arguments. We use lambdas, so the storage of arguments isn't needed, and this refactor no longer stores the PII in redis.
There is a bit of complication to this because in the synchronous process the form data that gets submitted is sometimes used after the proofer vendor returns a response, and the redis-stored PII was kind of a stand-in for that. To work with that, the
previous_..._paramspattern was copied to save the user's input and then used as necessary after the vendor returns a successful response.