Skip to content

Refactor async proofing data storage#4498

Merged
mitchellhenke merged 8 commits intomasterfrom
mitchellhenke/refactor-async-proofing
Dec 9, 2020
Merged

Refactor async proofing data storage#4498
mitchellhenke merged 8 commits intomasterfrom
mitchellhenke/refactor-async-proofing

Conversation

@mitchellhenke
Copy link
Contributor

Previously, the async proofing process would store the arguments used for the vendor proofing call as backgrounds jobs were intended to load inputs from Redis instead of figuring out how to have the background job store encrypt its arguments. We use lambdas, so the storage of arguments isn't needed, and this refactor no longer stores the PII in redis.

There is a bit of complication to this because in the synchronous process the form data that gets submitted is sometimes used after the proofer vendor returns a response, and the redis-stored PII was kind of a stand-in for that. To work with that, the previous_..._params pattern was copied to save the user's input and then used as necessary after the vendor returns a successful response.

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/refactor-async-proofing branch 2 times, most recently from 8a289a1 to c3c7c2c Compare December 8, 2020 21:40
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a first pass, but looks good! Will try to review more closely in a bit

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/refactor-async-proofing branch 2 times, most recently from c727b48 to 44a5d6c Compare December 8, 2020 22:56
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/refactor-async-proofing branch from b4fce6f to 3d4d4a3 Compare December 9, 2020 15:14
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@mitchellhenke mitchellhenke merged commit bb33b8a into master Dec 9, 2020
@mitchellhenke mitchellhenke deleted the mitchellhenke/refactor-async-proofing branch December 9, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants