Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/async-doc-refactor
branch
from
e8acd23 to
6e803aa
Compare
zachmargolis
approved these changes
Dec 7, 2020
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! Some nits, nothing big
Contributor
There was a problem hiding this comment.
❤️ so glad we could remove this line
spec/controllers/lambda_callback/document_proof_result_controller_spec.rb
Show resolved
Hide resolved
Comment on lines
227
to
-228
| dcs = DocumentCaptureSession.where(uuid: uuid).first_or_create | ||
| dcs.store_proofing_pii_from_doc(pii) # generates a result_id |
Contributor
There was a problem hiding this comment.
do we need to set a result_id? Since the #store_doc_auth_result won't make one?
Contributor
Author
There was a problem hiding this comment.
create_doc_auth_sessioncreates it 🙂
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
reviewed
Dec 7, 2020
spec/controllers/lambda_callback/document_proof_result_controller_spec.rb
Show resolved
Hide resolved
zachmargolis
reviewed
Dec 7, 2020
| pii: { | ||
| idv_result: { | ||
| success: true, errors: {}, messages: ['message'], | ||
| pii_from_doc: { |
Contributor
There was a problem hiding this comment.
style nit, indent the contents of the hash? give each of the keys above its own line?
…ler_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the Redis storage and classes so that the async doc auth uses its own data structure (with hopefully a more sensible interface)