Skip to content

fix newrelic method tracers#4489

Merged
mitchellhenke merged 1 commit intomasterfrom
mitchellhenke/hm
Dec 4, 2020
Merged

fix newrelic method tracers#4489
mitchellhenke merged 1 commit intomasterfrom
mitchellhenke/hm

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Dec 4, 2020

#4462 broke custom new relic method tracers because it has to be added after the method has been defined (docs)

Example of tracing disappearing (though we are still encrypting/verifying correctly):
image

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mitchellhenke mitchellhenke merged commit d08ea3b into master Dec 4, 2020
@mitchellhenke mitchellhenke deleted the mitchellhenke/hm branch December 4, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants