do not show alert if sp help text is a blank string#4487
Merged
mitchellhenke merged 1 commit intomasterfrom Dec 4, 2020
Merged
do not show alert if sp help text is a blank string#4487mitchellhenke merged 1 commit intomasterfrom
mitchellhenke merged 1 commit intomasterfrom
Conversation
zachmargolis
approved these changes
Dec 4, 2020
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, minor comments
Contributor
There was a problem hiding this comment.
let's fix the comment? it "is nil" maybe? or "it doesn't show anything"?
Contributor
There was a problem hiding this comment.
and lets fix the one on line 69 above too?
Contributor
Author
There was a problem hiding this comment.
oh wow, didn't even notice. good catch, updated
mitchellhenke
force-pushed
the
mitchellhenke/fix-empty-sp-alert
branch
from
3d5ddc9 to
3ea9c87
Compare
aduth
approved these changes
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially introduced by #4418 ?