Remove outdated dependencies (LG-3755)#4481
Conversation
| expect(response).to render_template(:new) | ||
| end | ||
|
|
||
| it 'logs Encryption::EncryptionError' do |
There was a problem hiding this comment.
This was somehow passing even though User doesn't have an unlock_user_access_key method (I think since f4adcf3)
There was a problem hiding this comment.
it's that allow(user).to receive(:unlock_user_access_key) LOL....stubbing 😭
There was a problem hiding this comment.
but it wouldn't be called to trigger the error that's expected either 😬
| end | ||
|
|
||
| def user_access_key | ||
| @_uak ||= user.unlock_user_access_key(password) |
There was a problem hiding this comment.
| gem 'rails', '~> 6.0.0' | ||
|
|
||
| gem 'ahoy_matey', '~> 2.2', '>= 2.2.1' | ||
| gem 'ahoy_matey', '~> 3.0' |
There was a problem hiding this comment.
we rely heavily on the format JSON of ahoy in our logs and parsing, have we spot-checked this to make sure the output to events.log is still good?
There was a problem hiding this comment.
I took a peek and the format seems the same. The bigger changes in the upgrade were around bot detection logic and dropping support for older versions of Rails: https://github.com/ankane/ahoy/blob/master/CHANGELOG.md#300-2019-05-29
mitchellhenke
deleted the
mitchellhenke/remove-outdated-dependencies-lg-3755
branch
3 participants
Uh oh!
There was an error while loading. Please reload this page.