Skip to content

LG-3694 Bumping identity-doc-auth version.#4478

Merged
amathews-fs merged 1 commit intomasterfrom
LG-3694-bump-doc-auth-gem-version
Dec 2, 2020
Merged

LG-3694 Bumping identity-doc-auth version.#4478
amathews-fs merged 1 commit intomasterfrom
LG-3694-bump-doc-auth-gem-version

Conversation

@amathews-fs
Copy link
Contributor

No description provided.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmargolis
Copy link
Contributor

this doesn't matter yet because we're not using lexisnexis in our lambdas...but eventually we're going to have to start updating https://github.com/18f/identity-idp-functions to reference the right versions of this

Maybe it's time we just start publishing these (already open source) gems to rubygems?

@zachmargolis
Copy link
Contributor

The reasons is that this is kind of a diamond/triangle dependency where we include identity-idp-functions here, and identity-idp-functions depends on identity-doc-auth.....

@amathews-fs amathews-fs merged commit c9a5af0 into master Dec 2, 2020
@amathews-fs amathews-fs deleted the LG-3694-bump-doc-auth-gem-version branch December 2, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants