Merged
Conversation
Contributor
|
Looks like we need to remove |
mitchellhenke
force-pushed
the
mitchellhenke/remove-slim-lg-3755
branch
from
07c9a47 to
85ac191
Compare
zachmargolis
approved these changes
Dec 2, 2020
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
HUGE!! LGTM, some small suggestions
Comment on lines
13
to
16
Contributor
There was a problem hiding this comment.
this link didn't end up in the SLIM, it's one of the blank strings right?
Contributor
Author
There was a problem hiding this comment.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/remove-slim-lg-3755
branch
from
914319f to
80bdd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the remaining slim templates to erb and removes the related gems
I tested all of the emails by manually sending both through mailcatcher and comparing them. There were also some blank internationalization strings that I removed.