Upload document capture images to S3 as PUT request

[aduth]

Why: Corrresponding to how the presigned URLs are configured, since it's expected that the user could need to change (replace) their selected image.

See: https://github.com/18F/identity-idp/blob/e1e8983/app/helpers/aws_s3_helper.rb#L8
Discussion: https://gsa-tts.slack.com/archives/CNCGEHG1G/p1605187899258500?thread_ts=1605046986.258200&cid=CNCGEHG1G

[solipet]

lgtm

[zachmargolis]

LGTM, one add-on request:

• Can we also update the fake local version too? (Make it PUT and change to update as the action name)

  • identity-idp/config/routes.rb

    Line 160 in 19872f2

    post '/s3/:key' => 'fake_s3#create'

  • identity-idp/spec/controllers/fake_s3_controller_spec.rb

    Line 35 in 19872f2

    post :create, body: data, params: { key: key }

[zachmargolis]

Can we also update the fake local version too? (Make it PUT and change to update as the action name)

Maybe we can update some acceptance specs to exercise this fake controller too? Unsure how big that is

[aduth]

Can we also update the fake local version too? (Make it PUT and change to update as the action name)

Yeah, good call. I'll update those.

Maybe we can update some acceptance specs to exercise this fake controller too? Unsure how big that is

Unsure off the top of my head, but I'll give it a shot, as it seems like a good thing to have.

[aduth]

Can we also update the fake local version too? (Make it PUT and change to update as the action name)

Updated in cd03568.

Maybe we can update some acceptance specs to exercise this fake controller too? Unsure how big that is

I've got some tests written in my local branch, though it turned out to be a big more of a rabbit hole than I expected, since we don't have much precedent for testing the document capture JavaScript in feature tests, and there's some basic setup required to resolve an issue with fetch not wanting to communicate with the test environment's domain_name (i.e. not actually the test environment's host name). While I've got it working, since it could do for some extra scrutiny, I'll plan to merge this as-is and create a quick follow-up pull request.