Skip to content

Use i18n-tasks to audit used JS locale strings#4378

Merged
aduth merged 6 commits intomasterfrom
aduth-audit-unused-js-strings
Nov 4, 2020
Merged

Use i18n-tasks to audit used JS locale strings#4378
aduth merged 6 commits intomasterfrom
aduth-audit-unused-js-strings

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Nov 3, 2020

Why:

As a developer, I want to be warned when the locale strings in use do not match those provided by the server, so I can have confidence that the texts will be presented correctly to the user.

As a developer, I want to have a well-known inventory of strings in use, so that I can have confidence in future refactoring if and how strings are being used.

As a developer, I want to leverage existing tooling, so that I can feel confidence in knowing that string usage is treated consistently, and so that I don't need to deal with the overhead of maintaining a custom translation string checking utility.

As a user, I want only the necessary translations to be included in the JavaScript assets, so that my pages load faster.

aduth added 6 commits November 3, 2020 17:09
**Why**:

As a developer, I want to be warned when the locale strings in use do not match those provided by the server, so I can have confidence that the texts will be presented correctly to the user.

As a developer, I want to have a well-known inventory of strings in use, so that I can have confidence in future refactoring if and how strings are being used.

As a developer, I want to leverage existing tooling, so that I can feel confidence in knowing that string usage is treated consistently, and so that I don't need to deal with the overhead of maintaining a custom translation string checking utility.

As a user, I want only the necessary translations to be included in the JavaScript assets, so that my pages load faster.
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 81e9c24 into master Nov 4, 2020
@aduth aduth deleted the aduth-audit-unused-js-strings branch November 4, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants