replace crockford encoding dependencies

[mitchellhenke]

Replaces vulnerable version of Crockford encoding library with a different one

I pulled out the encoding/decoding to be able to test easier, but I wasn't sure if there was a more appropriate place to put it?

[aduth]

I pulled out the encoding/decoding to be able to test easier, but I wasn't sure if there was a more appropriate place to put it?

packs can work, but each pack is treated as a distinct Webpack entrypoint, which means it'll generate an output JavaScript file. Normally, this would be intended to be used as standalone, brought into a page using javascript_pack_tag. The way we're using it is more as a utility module.

Instead, I'd imagine one of two alternatives:

• Keep it in app/javascript/packs/personal-key-page-controller.js. Your tests should be able to import from that file the same way they are currently from personal-key-input-encoder.js.
• Create it as a utility package in app/javascript/packages (documentation, prior art), which helps keep it a bit more self-contained as well.

[aduth]

Looks good 👍