Separate voice sms configs (LG-3517)#4331
Merged
zachmargolis merged 6 commits intomasterfrom Oct 22, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(builds on #4330)
Currently we have one
sms_only?config --- what that means is we assume SMS support for any country in our list, and sometimes have voice support.The process for updating the
.ymlfile was:supports_sms: truebecause that is what is implied by having a config at allsupports_voice: !sms_onlySMS only means "no voice" so we invert the previous config to expand that into the voice configA lot of these configs are out of date with our current vendor support, but the purpose of this PR is just to clarify the logic we have, and then we can true-up the configs in the follow-up