Skip to content

Fix intermittent IAA Billing Report test failures by sorting SPs #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Oct 9, 2020
Merged

Fix intermittent IAA Billing Report test failures by sorting SPs #4289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/services/reports/iaa_billing_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ def active_ial2_counts_for_iaa(sp)
def unique_iaa_sps
iaa_done = {}
sps = []
ServiceProvider.where.not(iaa: nil, iaa_start_date: nil, iaa_end_date: nil).each do |sp|
ServiceProvider.where.not(
iaa: nil,
iaa_start_date: nil,
iaa_end_date: nil,
).sort_by(&:issuer).each do |sp|
iaa = sp.iaa
(sps_for_iaa[iaa] ||= []) << sp
next if iaa_done[iaa]
Expand Down