Skip to content

async proofing verify call (LG-3330)#4235

Merged
mitchellhenke merged 7 commits intostevegsa-add-optional-show-steps-to-fsmfrom
mitchellhenke/async-proofing-calls2-lg-3330
Sep 25, 2020
Merged

async proofing verify call (LG-3330)#4235
mitchellhenke merged 7 commits intostevegsa-add-optional-show-steps-to-fsmfrom
mitchellhenke/async-proofing-calls2-lg-3330

Conversation

@mitchellhenke
Copy link
Contributor

follow up to #4213

Comment on lines +1 to +6
class ProofingDocumentCaptureSessionResult
REDIS_KEY_PREFIX = 'dcs-proofing:result'.freeze

attr_reader :id, :pii, :result

class << self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to EncryptedRedisStructStorage? #4217

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great question and that's what felt weird when I was moving things over. I'm not sure because it's not in #4213 at all...?

I'll manually bring over #4217 into this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachmargolis alright, fixed

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/async-proofing-calls2-lg-3330 branch 2 times, most recently from 38678dd to f4b6deb Compare September 23, 2020 20:32
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/async-proofing-calls2-lg-3330 branch from f4b6deb to 93548eb Compare September 23, 2020 20:33
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@zachmargolis
Copy link
Contributor

zachmargolis commented Sep 24, 2020

@mitchellhenke @stevegsa heads up, I pushed 0a6a36e, which applies logic from #4239 to the EncryptedRedisStructStorage in this PR

I figured it was easier to patch this here, before we got lost on another branch-of-a-branch

@mitchellhenke mitchellhenke merged commit ae97fcb into stevegsa-add-optional-show-steps-to-fsm Sep 25, 2020
@mitchellhenke mitchellhenke deleted the mitchellhenke/async-proofing-calls2-lg-3330 branch September 25, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants