Deploy RC 119 to Staging

.circleci/config.yml

@@ -184,32 +184,6 @@ jobs:
             bundle exec rubocop
             bundle exec slim-lint app/views
             make check_asset_strings
-  build-latest-container:
-    working_directory: ~/identity-idp
-    docker:
-      - image: circleci/ruby:2.6
-    steps:
-      - checkout
-      - setup_remote_docker
-      - run: |
-          rev=$(git rev-parse --short HEAD)
-          docker build -t logindotgov/idp:latest -t logindotgov/idp:"${rev}" -f production.Dockerfile .
-          echo $DOCKER_PASS | docker login -u $DOCKER_USER --password-stdin
-          docker push logindotgov/idp:"${rev}"
-          docker push logindotgov/idp:latest
-  build-latest-dev-container:
-    working_directory: ~/identity-idp
-    docker:
-      - image: circleci/ruby:2.6
-    steps:
-      - checkout
-      - setup_remote_docker
-      - run: |
-          rev=$(git rev-parse --short HEAD)
-          docker build -t logindotgov/dev:latest -t logindotgov/dev:"${rev}" -f development.Dockerfile .
-          echo $DOCKER_PASS | docker login -u $DOCKER_USER --password-stdin
-          docker push logindotgov/dev:"${rev}"
-          docker push logindotgov/dev:latest
   build-release-container:
     working_directory: ~/identity-idp
     docker:
@@ -285,12 +259,6 @@ workflows:
     jobs:
       - build
       - lints
-      - build-latest-dev-container:
-          requires:
-            - build
-      - build-latest-container:
-          requires:
-            - build
       - build-release-container:
           requires:
             - build

.eslintrc

@@ -42,7 +42,6 @@
       "app/components/index",
       "app/utils/index",
       "app/pw-toggle",
-      "app/form-validation",
       "app/form-field-format",
       "app/radio-btn",
       "app/print-personal-key",

.gitignore

@@ -39,16 +39,18 @@ Vagrantfile
 /config/aws.yml
 /config/service_providers.yml
 /config/agencies.yml
-/geo_data/*
-/keys
 /coverage
 /db/*.sqlite3
 /doc/search_stats.csv
 /docs/security/exports
 /docs/security/opencontrols
 /fixtures
+/geo_data/*
+/identity-idp-config
+/keys
 /kitchen/cookbooks
 /log/*
+/postgres-data
 /public/system
 /public/user_flows
 /pwned_passwords/*
@@ -58,7 +60,6 @@ Vagrantfile
 /tmp/*
 /.tmp/
 /vendor/bundle
-/postgres-data
 
 package-lock.json
 

.rubocop.yml

@@ -31,6 +31,9 @@ Metrics/AbcSize:
   Exclude:
   - spec/**/*
 
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
 Metrics/BlockLength:
   CountComments: false  # count full line comments?
   Enabled: true
@@ -74,8 +77,8 @@ Metrics/MethodLength:
 
 Metrics/ModuleLength:
   CountComments: false
-  Max: 100
-  Description: Avoid modules longer than 100 lines of code.
+  Max: 200
+  Description: Avoid modules longer than 200 lines of code.
   Enabled: true
   Exclude:
   - spec/**/*
@@ -351,3 +354,129 @@ Style/SlicingWithRange:
 
 Rails/ApplicationMailer:
   Enabled: false
+
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateRescueException:
+    Enabled: true
+
+Lint/FloatComparison:
+  Enabled: true
+
+Lint/MissingSuper:
+  Enabled: false
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
+Lint/RedundantRequireStatement:
+  Enabled: true
+
+Lint/RedundantSplatExpansion:
+  Enabled: true
+
+Lint/SafeNavigationWithEmpty:
+  Enabled: true
+
+Lint/SelfAssignment:
+  Enabled: true
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Style/GlobalStdStream:
+  Enabled: false
+
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Lint/EmptyConditionalBody:
+  Enabled: false
+
+Lint/UnreachableLoop:
+  Enabled: false
+
+Style/AccessorGrouping:
+  Enabled: false
+
+Style/ArrayCoercion:
+  Enabled: false
+
+Style/BisectedAttrAccessor:
+  Enabled: false
+
+Style/CaseLikeIf:
+  Enabled: false
+
+Style/ExplicitBlockArgument:
+  Enabled: false
+
+Style/HashAsLastArrayItem:
+  Enabled: false
+
+Style/HashLikeCase:
+  Enabled: false
+
+Style/OptionalBooleanParameter:
+  Enabled: false
+
+Style/SingleArgumentDig:
+  Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false
+
+Style/MultilineWhenThen:
+  Enabled: true
+
+Style/KeywordParametersOrder:
+  Enabled: true
+
+Lint/DuplicateRequire:
+  Enabled: true
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
+Lint/EmptyFile:
+  Enabled: false
+
+Lint/UselessMethodDefinition:
+  Enabled: false
+
+Style/CombinableLoops:
+  Enabled: false
+
+Style/RedundantSelfAssignment:
+  Enabled: false
+
+Style/SoleNestedConditional:
+  Enabled: false
+
+Lint/UselessTimes:
+  Enabled: true
+
+Layout/BeginEndAlignment:
+  Enabled: true
+
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
+Lint/IdentityComparison:
+  Enabled: true
+
+Bundler/DuplicatedGem:
+  Enabled: true
+
+Naming/BinaryOperatorParameterName:
+  Enabled: true

Gemfile

@@ -3,15 +3,15 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}.git" }
 
 ruby '~> 2.6.5'
 
-gem 'rails', '~> 5.2.4', '>= 5.2.4.3'
+gem 'rails', '~> 5.2.4', '>= 5.2.4.4'
 
 gem 'ahoy_matey', '~> 2.2', '>= 2.2.1'
 gem 'american_date'
 gem 'aws-sdk-kms', '~> 1.4'
 gem 'aws-sdk-ses', '~> 1.6'
 gem 'base32-crockford'
 gem 'device_detector'
-gem 'devise', '~> 4.7.1'
+gem 'devise', '~> 4.7.2'
 gem 'dotiw', '>= 4.0.1'
 gem 'exception_notification', '>= 4.4.0'
 gem 'faraday'
@@ -93,7 +93,7 @@ group :development, :test do
   gem 'psych'
   gem 'puma'
   gem 'rspec-rails', '~> 3.9', '>= 3.9.1'
-  gem 'rubocop', '~> 0.85.0', require: false
+  gem 'rubocop', '~> 0.91.0', require: false
   gem 'rubocop-rails', '>= 2.5.2', require: false
   gem 'slim_lint'
 end
@@ -107,8 +107,8 @@ group :test do
   gem 'factory_bot_rails', '>= 5.2.0'
   gem 'faker'
   gem 'gmail'
-  gem 'rack-test', '>= 1.1.0'
   gem 'rack_session_access', '>= 0.2.0'
+  gem 'rack-test', '>= 1.1.0'
   gem 'rails-controller-testing', '>= 1.0.4'
   gem 'shoulda-matchers', '~> 4.0.1', require: false
   gem 'timecop'