Skip to content

LG-3118 Change "Sign in" to "Continue" on user authorization confirmation #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
Sep 14, 2020
Merged

LG-3118 Change "Sign in" to "Continue" on user authorization confirmation #4189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/locales/user_authorization_confirmation/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
en:
user_authorization_confirmation:
continue: Sign in
continue: Continue
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use an existing/common continue button?

Copy link
Copy Markdown
Contributor Author

@jmhooper jmhooper Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, though we do run the risk of changing that having side effects on this screen where it is presented a little differently than it is elsewhere.

Copy link
Copy Markdown
Contributor

@anniehirshman-gsa anniehirshman-gsa Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw if we use common Continue button, we should make sure it's still center-aligned (usually it's left aligned, but here it's centered).

currently_logged_in: 'You are already signed in with the following email:'
or: Or
sign_in: Switch emails
8 changes: 4 additions & 4 deletions config/locales/user_authorization_confirmation/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
es:
user_authorization_confirmation:
continue: Sign in
currently_logged_in: 'You are already signed in with the following email:'
or: Or
sign_in: Switch emails
continue: Continuar
currently_logged_in: 'Ya estás registrado con el siguiente correo electrónico:'
or: O
sign_in: Cambiar de correo electrónico
8 changes: 4 additions & 4 deletions config/locales/user_authorization_confirmation/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
fr:
user_authorization_confirmation:
continue: Sign in
currently_logged_in: 'You are already signed in with the following email:'
or: Or
sign_in: Switch emails
continue: Continuer
currently_logged_in: 'Vous êtes déjà connecté avec l''e-mail suivant:'
or: ou
sign_in: Changer d'e-mail