Skip to content

Fix test flakiness: agencies factory #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Sep 10, 2020
Merged

Fix test flakiness: agencies factory #4186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions spec/factories/agencies.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
FactoryBot.define do
factory :agency do
agency_name_templates = [
'Department of %{industry}',
'Bureau of %{industry}',
'%{industry} Administration',
'%{industry} Agency',
'Department of %{industry} %{tag}',
'Bureau of %{industry} %{tag}',
'%{industry} Administration %{tag}',
'%{industry} Agency %{tag}',
]

id { Agency.last&.id.to_i + 1 } # autoincrementer is messed up for this table
name { format(agency_name_templates.sample, industry: Faker::Company.industry) }
name do
format(agency_name_templates.sample,
industry: Faker::Company.industry,
tag: SecureRandom.hex)
end
end
end