Skip to content

Convert a few more slim templates#4183

Merged
mitchellhenke merged 4 commits intomasterfrom
mitchellhenke/slim-templates
Sep 10, 2020
Merged

Convert a few more slim templates#4183
mitchellhenke merged 4 commits intomasterfrom
mitchellhenke/slim-templates

Conversation

@mitchellhenke
Copy link
Contributor

No description provided.

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/slim-templates branch from cc2e1cc to b0545ea Compare September 10, 2020 20:11
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

</div>

<p class="mb4">
<%= t('forms.backup_code.caution_delete') %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one had == before, does it need to be marked as raw?

Copy link
Contributor Author

@mitchellhenke mitchellhenke Sep 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</div>

<p class="mb4">
<%= t('forms.backup_code_regenerate.caution') %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto re: == and raw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Maybe they used to have something. Thanks for checking

@mitchellhenke mitchellhenke merged commit 4b6c879 into master Sep 10, 2020
@mitchellhenke mitchellhenke deleted the mitchellhenke/slim-templates branch September 10, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants