Conversation
**Why**: LG-3104 **How**: CSS tweaks **How**: Redo banner close button (mobile) w/html + js
|
Desktop view evident from Preview. Mobile view before: Mobile view after: |
app/views/shared/_banner.html.erb
Outdated
| </div> | ||
| </div> | ||
| </div> | ||
| <button class="mobile close-banner-how-you-know" aria-label="close banner popup"></button> |
There was a problem hiding this comment.
Do we want to translate the aria-label?
There was a problem hiding this comment.
Ugh...good call. Going too fast. Thx.
| } | ||
|
|
||
| .close-banner-how-you-know { | ||
| background: url(#{$image-path}/close-primary.svg) top left no-repeat; |
There was a problem hiding this comment.
I noticed a console error in unrelated testing in the development environment, I suspect is caused by this.
[Error] Failed to load resource: the server responded with a status of 403 () (close-primary.svg, line 0)
Based on how images are referenced in other stylesheets, I suspect this should be image-path helper?
| background: url(#{$image-path}/close-primary.svg) top left no-repeat; | |
| background: url(image-path('close-primary.svg')) top left no-repeat; |
There was a problem hiding this comment.
I tried this, but it doesn't fix it. Does the image exist?
There was a problem hiding this comment.
It's in the identity-style-guide:
identity-site:master> find node_modules -name '*close-primary.svg'
node_modules/identity-style-guide/dist/assets/img/close-primary.svg
There was a problem hiding this comment.
shucks...it worked locally, but clearly something is amiss...easy fix would be to copy node_modules/identity-style-guide/dist/assets/img/close-primary.svg into the path referenced by the image-path helper, but I'd still be left wondering how the dist assets are supposed to be reached...
In any event, good catch @mitchellhenke
There was a problem hiding this comment.
I get GET http://localhost:3000/images/close-primary.svg 404 (Not Found) with it locally
There was a problem hiding this comment.
It gets copied to:
identity-site:master> find _site -name '*close-primary.svg'
_site/assets/img/close-primary.svg
EDIT: whoops, my brain is fried, this is the wrong repo
There was a problem hiding this comment.
After git pulling on master, I can't get the project to run anymore. Seems like the webpack build is not quite working...stay tuned...
There was a problem hiding this comment.
Continually getting this:
There was a problem hiding this comment.
#4171 may be the solution. Draft PR built successfully.
4 participants
Why: LG-3104
How: CSS tweaks
How: Redo banner close button (mobile) w/html + js