LG-3267: Display success alert if ID submission is successful#4165
Merged
LG-3267: Display success alert if ID submission is successful#4165
Conversation
zachmargolis
approved these changes
Sep 3, 2020
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, small q's no big blockers
aduth
commented
Sep 4, 2020
app/views/idv/doc_auth/ssn.html.erb
Outdated
Contributor
Author
There was a problem hiding this comment.
The additional mobile-only margins here were because the natural margin above the notice is quite small (smaller than designed) in mobile displays. However, it has me wondering if, rather than adding margins ad hoc like this, if we'd want to consider increasing the default padding of the body container in the mobile stylesheet.
Not in scope for this issue, but an idea which occurred to me nonetheless.
Contributor
There was a problem hiding this comment.
@aduth thanks for flagging this! Yes, let's keep this in the back of our minds address in either the spacing or typography updates.
**Why**: For consistent rendering of notice alerts, and consolidated logic around assignment of relevant attributes (role, etc)
As a user, I want to see an alert message that lets me know if my ID passed, so that I know my upload was successful as I move on to the next step in verifying my identity.
Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
aduth
force-pushed
the
aduth-3267-success-alert
branch
from
65adc37 to
6a42714
Compare
jmhooper
approved these changes
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a user, I want to see an alert message that lets me know if my ID passed, so that I know my upload was successful as I move on to the next step in verifying my identity.
Screenshots: