Merged
Conversation
aduth
commented
Aug 26, 2020
spec/javascripts/packages/document-capture/components/document-capture-spec.jsx
Outdated
Show resolved
Hide resolved
a119a18 to
50a65d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a developer, I expect that I can pass translated text strings for Acuant's capture display, and that I am taking advantage of the latest improvements to the SDK published in recent releases.
LG-3340 will require a newer version of Acuant than we are currently using, since the release which added support for overriding text strings (11.3.2) is newer than the version we currently use (11.3.1). The current version of Acuant is 11.4.1.
Implementation Notes:
The proposed changes will upgrade us from 11.3.1 to 11.4.1 (latest version), which should keep us in closer alignment with current release and potentially simplify future upgrades.
The upgrade from 11.3 to 11.4 includes some breaking changes. See migration guide.
The largest impact for us appears to be in how
AcuantCameraUI.startworks:{ onCaptured, onCropped, onFrameAvailable? }onCapturedis required, even if not used.onFrameAvailablecan safely be omitted.onCapturedas an opportunity to update the UI to show a completed-but-pending-cropping UI state.These are updated in both existing production document flow, as well as the upcoming React implementation. The first of the points above only affects existing flow, since this is managed separately in the React application (source).
Other minor notes:
AcuantImageProcessingService.wasmwas removed and replaced byAcuantImageProcessingService.js.mem, which requires a few server-side revisions.