Add TypeScript tooling for JavaScript type-checking#4043
Merged
Conversation
**Why:** To take advantage of TypeScript-based type checking.
**Why**: To improve confidence in our component props usage.
**Why**: To prevent errors from being inadvertently introduced.
aduth
added a commit
that referenced
this pull request
Aug 12, 2020
**Why**: PropTypes were removed in favor of TypeScript-validated JSDoc See: #4043
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To improve confidence in our code. The error fixed in #4040 would have never happened if these changes had been in place.
Applies only to new code in
app/javascripts/app/document-capture(the React-based document capture flow).See also: #4040
This removes
prop-typesand disables the associated ESLint configuration.From #4040: