Skip to content

Use animated ID card for doc auth loading interstitial #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 4 commits into from
Aug 3, 2020
Merged

Use animated ID card for doc auth loading interstitial #4003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97eb1ad
Use animated ID card for doc auth loading interstitial
aduth Aug 3, 2020
f452535
Add mechanism to bypass SVG style test spec
aduth Aug 3, 2020
9bb29c2
Rename test override pattern to lint-ignore
aduth Aug 3, 2020
ebfd2cd
Use percent literal syntax for regular expression pattern
aduth Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions app/assets/images/id-card.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions app/assets/javascripts/assets.js.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ window.LoginGov = window.LoginGov || {};
window.LoginGov.assets = {};

<% keys = [
'clock.svg',
'close-white-alt.svg'
'close-white-alt.svg',
'id-card.svg',
] %>

<% keys.each do |key| %>
Expand Down
2 changes: 1 addition & 1 deletion app/javascript/app/document-capture/components/submission-pending.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Image from './image';
function SubmissionPending() {
return (
<div>
<Image assetPath="clock.svg" alt="" width="50" height="50" />
<Image assetPath="id-card.svg" alt="" width="216" height="116" />
<h2>We are processing your images…</h2>
<p>This might take up to a minute. We’ll load the next step automatically when it’s done.</p>
<p>Thanks for your patience!</p>
Expand Down
4 changes: 3 additions & 1 deletion spec/svg_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
it 'does not contain inline style tags (that render poorly in IE due to CSP)' do
doc = Nokogiri::XML(File.read(svg_path))

expect(doc.css('style')).to be_empty
expect(doc.css('style')).to be_empty.or(
have_attributes(text: match(%r{^\s*/\*\s*lint-ignore\s*\*/})),
)
end
end
end
Expand Down