Conversation
aduth
commented
Jul 20, 2020
**Why**: History#pushState cannot operate on origin about:blank, the default JSDOM URL
**Why**: setupDocumentCaptureTestDOM is called before _each_ test case within the Acuant tests, whereas the tear down is only called once at the end of the test suite. This has the result that assigning originalWindow in beforeEach may in-fact be tracking the newly-created Acuant DOM as the original. The alternative to this is to tear down after each test case. However, with recent changes, it's assumed that the DOM should be ready to use at import-time, such that this should be safe.
**Why**: To manage common behaviors of form values aggregation and history of a linear, step-based form.
**Why**: These texts are unlikely to change and are already readily available. See: #3952 (comment)
**Why**: Airbnb doesn't document this rule. It's assumed the spirit of the intent of this rule is to ensure consistency of one element per line when splitting elements across multiple lines. This is accounted for by Prettier. However, the rule is more strict in how it allows multiple elements within the same line, in a way which Prettier neither applies, nor does Airbnb prescribe, nor is in contradiction to this spirit of the guideline.
Contributor
Author
|
Per the discussions at #3952 (comment) and #3952 (comment), I took another shot at extracting a general-purpose A couple notes:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why: To manage common behaviors of form values aggregation and history of a linear, step-based form.
Screen Recording:
The included example is provided for demonstration only, and is not intended to be styled or representative of a final flow. The intent of these changes is to prepare an apparatus for step-based forms flow which accumulates a single payload object, and which can be revised by the user using their browser history.