Add Make task to validate asset strings#3935
Closed
ironman5366 wants to merge 12 commits intomasterfrom
Closed
Conversation
**Why**: Asset paths include a fingerprint which can't be known to the client unless provided by the server. Co-authored-by: Will Beddow <william.beddow@gsa.gov>
**Why**: Current Login.gov pages will check for and initialize any accordions present at page load. Since React components can be mounted after page load, and also need to initialize, there should be internal checks to protect against double initialization, since otherwise event handlers may be triggered multiple times.
**Why**: As an abstraction to simply render an image at the known asset path, encapsulating behavior to perform asset lookup by asset context
**Why**: If classList.js is imported (directly or indirectly) through any tested files, an error will occur. See inline comment for additional details.
**Why**: In order to use React Fragment JSX shorthand syntax, the babel-eslint dependency must be upgraded.
**Why**: To recreate the existing document capture flow, we will need to be able to represent collapsible accordion content in React
**Why**: Recreating the existing document capture flow requires integrating existing tips content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New JS code added in #3909 and others require strings configured in
assets.js.erbandi18n-strings.js.erb.The added make task,
check_asset_strings, assets that for each such string referenced in a Javascript file, there exists a corresponding entry in one of the erb files