Conversation
**Why**: As a developer, I want linting on my JSX files so that I can be certain of authoring quality code. See: https://docs.codeclimate.com/docs/eslint#extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: LG-3023, #3903
By default, both ESLint and CodeClimate will only check files with
.jsfile extension. This would prevent legitimate linting errors in.jsxfiles from being flagged. The changes proposed here reconfigure CodeClimate to check.jsxfiles, and introduces a new NPM script for linting, which includes JSX file checking.Why: As a developer, I want linting on my JSX files so that I can be certain of authoring quality code.
Note that with the changes in #3903 to use eslint-config-airbnb instead of eslint-config-airbnb-base, it's expected ESLint should already be configured to handle JSX syntax (see base config source).
See CodeClimate documentation: https://docs.codeclimate.com/docs/eslint#extensions
See ESLint CLI documentation: https://eslint.org/docs/user-guide/command-line-interface#options