-
Notifications
You must be signed in to change notification settings - Fork 166
LG-3175: Create localization utilities for React components #3909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 5 additions & 1 deletion
6
app/javascript/app/document-capture/components/document-capture.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| import useI18n from '../hooks/use-i18n'; | ||
|
|
||
| function DocumentCapture() { | ||
| return 'Document Capture'; | ||
| const t = useI18n(); | ||
|
|
||
| return t('doc_auth.headings.welcome'); | ||
| } | ||
|
|
||
| export default DocumentCapture; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { createContext } from 'react'; | ||
|
|
||
| const I18nContext = createContext({}); | ||
|
|
||
| export default I18nContext; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { useContext } from 'react'; | ||
| import I18nContext from '../context/i18n'; | ||
|
|
||
| function useI18n() { | ||
| const strings = useContext(I18nContext); | ||
| const t = (key) => ( | ||
| Object.prototype.hasOwnProperty.call(strings, key) ? strings[key] : key | ||
| ); | ||
| return t; | ||
| } | ||
|
|
||
| export default useI18n; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,15 @@ | ||
| import React from 'react'; | ||
| import { render } from 'react-dom'; | ||
| import DocumentCapture from '../app/document-capture/components/document-capture'; | ||
| import I18nContext from '../app/document-capture/context/i18n'; | ||
|
|
||
| const { I18n: i18n } = window.LoginGov; | ||
zachmargolis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const appRoot = document.getElementById('document-capture-form'); | ||
| appRoot.innerHTML = ''; | ||
| render( | ||
| <DocumentCapture />, | ||
| <I18nContext.Provider value={i18n.strings[i18n.currentLocale()]}> | ||
| <DocumentCapture /> | ||
| </I18nContext.Provider>, | ||
| appRoot, | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
spec/javascripts/app/document-capture/context/i18n-spec.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import React, { useContext } from 'react'; | ||
| import { render } from '@testing-library/react'; | ||
| import I18nContext from '../../../../../app/javascript/app/document-capture/context/i18n'; | ||
| import { useDOM } from '../../../support/dom'; | ||
|
|
||
| describe('document-capture/context/i18n', () => { | ||
| useDOM(); | ||
|
|
||
| const ContextValue = () => JSON.stringify(useContext(I18nContext)); | ||
|
|
||
| it('defaults to empty object', () => { | ||
| const { container } = render(<ContextValue />); | ||
|
|
||
| expect(container.textContent).to.equal('{}'); | ||
| }); | ||
| }); |
27 changes: 27 additions & 0 deletions
27
spec/javascripts/app/document-capture/hooks/use-i18n-spec.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import React from 'react'; | ||
| import { render } from '@testing-library/react'; | ||
| import I18nContext from '../../../../../app/javascript/app/document-capture/context/i18n'; | ||
| import useI18n from '../../../../../app/javascript/app/document-capture/hooks/use-i18n'; | ||
| import { useDOM } from '../../../support/dom'; | ||
|
|
||
| describe('document-capture/hooks/use-i18n', () => { | ||
| useDOM(); | ||
|
|
||
| const LocalizedString = ({ stringKey }) => useI18n()(stringKey); | ||
|
|
||
| it('returns localized key value', () => { | ||
| const { container } = render( | ||
| <I18nContext.Provider value={{ sample: 'translation' }}> | ||
| <LocalizedString stringKey="sample" /> | ||
| </I18nContext.Provider>, | ||
| ); | ||
|
|
||
| expect(container.textContent).to.equal('translation'); | ||
| }); | ||
|
|
||
| it('falls back to key value', () => { | ||
| const { container } = render(<LocalizedString stringKey="sample" />); | ||
|
|
||
| expect(container.textContent).to.equal('sample'); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.