Skip to content

LG-2959 Add a missing return statement when a Acuant SDK file is not permitted #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
May 13, 2020
Merged

LG-2959 Add a missing return statement when a Acuant SDK file is not permitted #3765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/acuant_sdk_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class AcuantSdkController < ApplicationController

def show
# Only render files on an allowlist to prevent path traversal issues
render plain: 'Not found', status: :not_found unless requested_asset_permitted?
return render(plain: 'Not found', status: :not_found) unless requested_asset_permitted?

SecureHeaders.append_content_security_policy_directives(
request,
Expand Down
6 changes: 6 additions & 0 deletions spec/requests/acuant_sdk_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,11 @@

expect(response.status).to eq(404)
end

it 'renders a 404 for map files' do
get '/verify/doc_auth/AcuantImageProcessingService.wasm.map'

expect(response.status).to eq(404)
end
end
end