LG-2599 Drop SSN uniqueness constraint#3647
Merged
zachmargolis merged 12 commits intomasterfrom Mar 26, 2020
Merged
Conversation
**Why**: Some people have the same SSN. The SSN uniqueness constraint also means that if someone proofs and loses their password and access to their email they cannot create another proofed account.
Contributor
jmhooper
commented
Mar 26, 2020
|
|
||
| attr_accessor :ssn | ||
|
|
||
| validates :ssn, presence: true |
Contributor
Author
There was a problem hiding this comment.
The profile step actually is not part of the doc auth flow (long story). We'll actually want the SSN unique bit in the extra attributes of the form response coming out of this form.
Contributor
Author
There was a problem hiding this comment.
Looks like it, yeah
Contributor
Author
|
✅ Approved! (I can't approve since this was originally my PR) |
zachmargolis
approved these changes
Mar 26, 2020
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
Approving in lieu of @jmhooper:
✅ Approved! (I can't approve since this was originally my PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Some people have the same SSN. The SSN uniqueness constraint also means that if someone proofs and loses their password and access to their email they cannot create another proofed account.