LG-2246 Fix phone edit authorization issues#3410
Merged
Conversation
**Why**: There was a bug that was resulting in a 500 error if someone tried to edit a phone that did not belong to them by changing the ID in the URL. This happened because the resulting `PhoneConfiguration` query returned nil resulting in a `NoMethodError` on `NilClass` when we tried to read things from the phone configuration. This commit fixes this issue and a few others by breaking the edit phone funcitonality out of the phones controller into its own controller.
jmhooper
commented
Nov 14, 2019
achapm
reviewed
Nov 15, 2019
achapm
reviewed
Nov 15, 2019
Contributor
Author
|
@achapm: I think I have addressed all of your comments. Wanna take another look? |
jmhooper
commented
Nov 18, 2019
| end | ||
| end | ||
|
|
||
| def delete |
Contributor
Author
There was a problem hiding this comment.
This action should have a check for whether this will result in less than 2 MFA configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: There was a bug that was resulting in a 500 error if someone tried to edit a phone that did not belong to them by changing the ID in the URL. This happened because the resulting
PhoneConfigurationquery returned nil resulting in aNoMethodErroronNilClasswhen we tried to read things from the phone configuration.This commit fixes this issue and a few others by breaking the edit phone funcitonality out of the phones controller into its own controller.