Skip to content

LG-1383 Send emails for error conditions in add email#3075

Merged
stevegsa merged 6 commits intomasterfrom
stevegsa-add-email-confirm-emails
Jul 9, 2019
Merged

LG-1383 Send emails for error conditions in add email#3075
stevegsa merged 6 commits intomasterfrom
stevegsa-add-email-confirm-emails

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jul 7, 2019

Why: So users do not have to click on confirmation emails to tell them if their email is associated with another account

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • When fetching a single record from the database, #take is used instead
    of #first unless there is an #order call on the ActiveRecord relations.
    This prevents ActiveRecord from sorting by primary key which can result in slow
    queries.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

stevegsa added 3 commits July 7, 2019 19:22
**Why**: So users do not have to click on confirmation emails to tell them if their email is associated with another account
@stevegsa
Copy link
Contributor Author

stevegsa commented Jul 8, 2019

Screenshot:

Screen Shot 2019-07-08 at 12 22 39 AM

Fashioned after the existing email for create account:

Screen Shot 2019-07-09 at 1 02 46 PM

@@ -0,0 +1,35 @@
p.lead == t('.intro', app: link_to(APP_NAME, Figaro.env.mailer_domain_name, class: 'gray'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion... convert this to .html.erb

Copy link
Contributor

@achapm achapm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs UX review for content. I made a suggestion above. Otherwise, 👍

Copy link

@mguzman-gov mguzman-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the body text to read as follows:
"This email address is already associated with a login.gov account, so we can’t add it to another account. You must first delete or remove it from the account it is associated with. To do this, follow the link below and sign in with this email address. If you are not trying to add this email address to an account, you can ignore this message."

@stevegsa
Copy link
Contributor Author

stevegsa commented Jul 9, 2019

Updated copy per @mguzman-gov

Screen Shot 2019-07-09 at 1 52 20 PM

@stevegsa stevegsa merged commit 7d0d541 into master Jul 9, 2019
@amathews-fs amathews-fs deleted the stevegsa-add-email-confirm-emails branch January 7, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants