Skip to content

LG-422 Prevent create account using passwords from known breaches#3074

Merged
stevegsa merged 11 commits intomasterfrom
stevegsa-pwned-password
Jul 12, 2019
Merged

LG-422 Prevent create account using passwords from known breaches#3074
stevegsa merged 11 commits intomasterfrom
stevegsa-pwned-password

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jul 6, 2019

How: Use the pwned password database locally and do a custom binary search lookup. log(550mil records) = 20 seeks * average seek time 0.1ms (ssd) = 2ms per call with very low call volume

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • When fetching a single record from the database, #take is used instead
    of #first unless there is an #order call on the ActiveRecord relations.
    This prevents ActiveRecord from sorting by primary key which can result in slow
    queries.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@stevegsa stevegsa marked this pull request as ready for review July 6, 2019 05:28
@stevegsa stevegsa requested a review from mguzman-gov July 6, 2019 05:29
@stevegsa
Copy link
Contributor Author

stevegsa commented Jul 6, 2019

Screenshots:

Screen Shot 2019-07-12 at 6 53 26 AM

Copy link

@mguzman-gov mguzman-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update content to "The password you entered is not safe. It's in a list of known passwords exposed in data breaches."

achapm
achapm previously approved these changes Jul 9, 2019
Copy link
Contributor

@achapm achapm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stevegsa stevegsa force-pushed the stevegsa-pwned-password branch from 690d021 to 554632c Compare July 12, 2019 05:10
@stevegsa stevegsa force-pushed the stevegsa-pwned-password branch from 0c9dccb to 10ee60f Compare July 12, 2019 05:13
@jmhooper jmhooper dismissed achapm’s stale review July 12, 2019 13:04

Lots of changes since this review

@stevegsa stevegsa merged commit 43ecbd6 into master Jul 12, 2019
@amathews-fs amathews-fs deleted the stevegsa-pwned-password branch January 7, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants