Skip to content

LG-1330 generate backup codes on post#3044

Merged
achapm merged 39 commits intomasterfrom
LG-1330_generate_bkp_codes_on_post
Jul 10, 2019
Merged

LG-1330 generate backup codes on post#3044
achapm merged 39 commits intomasterfrom
LG-1330_generate_bkp_codes_on_post

Conversation

@achapm
Copy link
Contributor

@achapm achapm commented Jun 26, 2019

WHY: As a user, I want to know that my backup codes are functional when I see them, so that I am not confused about why the backup codes I saved aren't working

UX REVIEW:

SCENARIO #1 - When I sign up for a new account and choose backup codes:
image

[New Page]
image

SCENARIO #2 - When I have used my last backup code to sign in:

image

[New Page]
image

@achapm achapm changed the title saving controller changes LG-1330 generate backup codes on post Jun 26, 2019
@achapm achapm requested review from donjo, mguzman-gov and nickttng June 27, 2019 18:05
Copy link
Contributor

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me.

Just realized that the actual link to continue with backup doesn't match what the above copy text said: 'click the continue button below to proceed...`

The 'continue button' isn't really a button to click on, and users may be confused that they would click on the 'choose other option' button, thinking that's the continue button if they read too fast

@lauraGgit
Copy link

For scenario #2, would it make sense on that page to also use that as an opportunity to encourage them to select a more secure method? (also ok to say that that would be another story)

@nickttng
Copy link
Contributor

nickttng commented Jun 27, 2019

@achapm (and others) Concept that may clarify and simplify the reading flow

Screen Shot 2019-06-27 at 3 23 31 PM

@mguzman-gov
Copy link

@achapm it's a lot of text so here's a suggestion to shorten it. Also, general rule, we should use the term "authentication methods" not "security options".

"Are you sure this is your only option?
Backup codes are not recommended because they can easily be lost or stolen. If you have access to another authentication method, please choose another option.
If you don’t have access to any other authentication method, continue with backup codes."

"Create new backup codes
You used all of your backup codes. We will generate new backup codes after you click continue. Save them in a safe place to make sure you can sign in again in the future. "

I suggest removing the the second piece on create new backup codes because users have no way or instruction on setting up a second MFA from this screen. If we want to include this, then we at least need to add a link at the bottom.

@achapm
Copy link
Contributor Author

achapm commented Jun 28, 2019

@lauraGgit @nickttng
Thanks for the great feedback! I made the recommended changes and replaced the screenshots in the descriptions above.

@nickttng
Copy link
Contributor

@achapm New screenshot flows much better. 👍

@achapm
Copy link
Contributor Author

achapm commented Jul 1, 2019

@mguzman-gov
I complete the content updates you posted. Thank you very much!

Question...
I ran these through google translate for FR and SP. Should I create a follow up story for these translations or should I create a task as part of this story?

Copy link

@mguzman-gov mguzman-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good. Spanish and French are good to go too.

@achapm achapm marked this pull request as ready for review July 3, 2019 19:45
@achapm achapm requested review from cpbgsa, jmhooper and stevegsa and removed request for donjo July 3, 2019 19:45
include Rails.application.routes.url_helpers
include ActionView::Helpers::TranslationHelper

def initialize(view)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you saving the view context here? It looks like it isn't used in the presenter?

@achapm achapm requested a review from jmhooper July 9, 2019 16:20
@achapm achapm merged commit 616991f into master Jul 10, 2019
@amathews-fs amathews-fs deleted the LG-1330_generate_bkp_codes_on_post branch January 7, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants