Skip to content

Adds SBA Connect service provider configuration#3037

Merged
jmhooper merged 1 commit intomasterfrom
as-config-sba_connect
Jun 25, 2019
Merged

Adds SBA Connect service provider configuration#3037
jmhooper merged 1 commit intomasterfrom
as-config-sba_connect

Conversation

@amoose
Copy link
Contributor

@amoose amoose commented Jun 24, 2019

Adds SBA Connect SP configuration

Promoted from: https://dashboard.int.identitysandbox.gov/service_providers/382

  • Approved by SBA PoC

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • When fetching a single record from the database, #take is used instead
    of #first unless there is an #order call on the ActiveRecord relations.
    This prevents ActiveRecord from sorting by primary key which can result in slow
    queries.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@amoose amoose force-pushed the as-config-sba_connect branch from 262d255 to 5df8a1a Compare June 25, 2019 02:26
friendly_name: 'SBA Connect'
agency: 'SBA'
ial: 1
logo: 'sba_connect.png'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the logo is missing on the PR

@blacktm
Copy link
Contributor

blacktm commented Jun 25, 2019

Logo looks a little low res and cropped strangely. I wonder if they’d be open to using a vector one from https://www.sba.gov/brand/visual-identity/logo

@jmhooper jmhooper merged commit c1cd3de into master Jun 25, 2019
@amoose amoose deleted the as-config-sba_connect branch July 14, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants