Replace some AR calls to first with take#2889
Merged
Conversation
**Why**: Using `#first` adds a sort by pkey to the query which results in a slower query, in some cases daramtically slower. In situations where we don't care how the records are sorted we should use `#take` for better performance.
lauraGgit
reviewed
Apr 10, 2019
lauraGgit
left a comment
lauraGgit
left a comment
There was a problem hiding this comment.
Add something to issue template about take on ActiveRecord relations/ and possible in ruboCop
|
@jmhooper do you think that you'll be able to add a note on the PR template related to the take? |
Contributor
Author
|
@lauraGgit: I added a note to the "Database" section of the PR template |
This was referenced Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Using
#firstadds a sort by pkey to the query which results in a slower query, in some cases daramtically slower. In situations where we don't care how the records are sorted we should use#takefor better performance.