Skip to content

Remove legacy attribute and session encryptor#2711

Merged
jmhooper merged 3 commits intomasterfrom
jmhooper-remove-legacy-attribute-encryption
Jan 7, 2019
Merged

Remove legacy attribute and session encryptor#2711
jmhooper merged 3 commits intomasterfrom
jmhooper-remove-legacy-attribute-encryption

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Jan 4, 2019

Why: We have moved all of the attributes away from the old attribute
encryption method and we have definitely dropped all of the sessions
that were encrypted with the old encryptor.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

**Why**: We have moved all of the attributes away from the old attribute
encryption method and we have definitely dropped all of the sessions
that were encrypted with the old encryptor.
it 'renders the show page' do
post :create, params: payload
expect(response).to render_template(:show)
puts flash[:error]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did we run the bulk migration in prod?

@jmhooper
Copy link
Contributor Author

jmhooper commented Jan 7, 2019

Yep, there shouldn't be any more legacy ciphertexts in dev, int, staging, or prod.

@jmhooper jmhooper merged commit 9934b92 into master Jan 7, 2019
@jmhooper jmhooper deleted the jmhooper-remove-legacy-attribute-encryption branch February 15, 2019 18:00
Copy link

@ayoubbakkar123 ayoubbakkar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[REDACTED]

Note: Comment edited by repository maintainers to remove sensitive content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants