Closed
Conversation
**Why**: To make it easier to query how many users have configured MFA.
For example: `User.count(:mfa_enabled)`
Note that you want to use the above command, not any of these:
```
User.count(&:mfa_enabled)
User.count(&:mfa_enabled?)
```
The former does `SELECT COUNT("users"."mfa_enabled") FROM "users"`
whereas the latter ones use Ruby's Enumerable, which is a lot slower.
I believe the former is also faster than this:
```
User.where(mfa_enabled: true).count
```
What I don't know is whether the former benefits from an index.
0dc1cc0 to
33fe31f
Compare
Contributor
Author
|
This is a work in progress to get things started for LG-802. I probably won't have time to add tests before I leave. |
Contributor
Author
|
Things to consider:
|
Contributor
Author
|
We also need a script to backfill the |
Contributor
|
Closing this for now. We are looking at solutions for this that don't involve adding more indexes to the user table. |
This was referenced Aug 5, 2021
This was referenced Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To make it easier to query how many users have configured MFA.
For example:
User.count(:mfa_enabled)Note that you want to use the above command, not any of these:
The former does
SELECT COUNT("users"."mfa_enabled") FROM "users"whereas the latter ones use Ruby's Enumerable, which is a lot slower.
I believe the former is also faster than this:
What I don't know is whether the former benefits from an index.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticatedas the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
Encryption
Routes
state or result in destructive behavior).
Session
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.