Skip to content

LG-575 Add a phone#2662

Merged
stevegsa merged 16 commits intomasterfrom
stevegsa-add-a-phone
Nov 19, 2018
Merged

LG-575 Add a phone#2662
stevegsa merged 16 commits intomasterfrom
stevegsa-add-a-phone

Conversation

@stevegsa
Copy link
Contributor

Why: We want the user to be able to add multiple phone numbers to their account without replacing any already configured.

How: Replace the generic user.phone_configurations.first, which assumed one phone, with specific phone ids. Pass these ids when managing, updating, and authenticating. Create a new screen for adding a phone fashioned after the existing edit phone screen.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@stevegsa stevegsa force-pushed the stevegsa-add-a-phone branch from bcba7ee to c215b3c Compare November 16, 2018 04:09
@stevegsa
Copy link
Contributor Author

Screenshots:

After initial setup with one phone:
screen shot 2018-11-15 at 11 14 55 pm

Click add phone:
screen shot 2018-11-15 at 11 15 05 pm

screen shot 2018-11-15 at 11 15 21 pm

User now has two phones:
screen shot 2018-11-15 at 11 15 29 pm

When signing in:
screen shot 2018-11-15 at 11 17 19 pm

When clicking manage phone on the accounts screen:
screen shot 2018-11-15 at 11 17 47 pm

After delete:
screen shot 2018-11-15 at 11 17 58 pm

**Why**: We want the user to be able to add multiple phone numbers to their account without replacing any already configured.

**How**: Replace the generic user.phone_configurations.first, which assumed one phone, with specific phone ids.  Pass these ids when managing, updating, and authenticating.  Create a new screen for adding a phone fashioned after the existing edit phone screen.
@stevegsa stevegsa force-pushed the stevegsa-add-a-phone branch from 448c8a1 to e4b6dfd Compare November 19, 2018 03:23
MfaContext.new(current_user).phone_configuration(session[:phone_id])
end

def masked_number(number)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue introduced here, but may be worth noting that this is going to incorrectly format international numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants