Skip to content

LG-742 Create password screen allows less than 12 characters #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevegsa merged 2 commits into from
Nov 15, 2018
Merged

LG-742 Create password screen allows less than 12 characters #2657

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f0660d
LG-742 Create password screen allows less than 12 characters
stevegsa Nov 14, 2018
767ffb3
Merge branch 'master' into stevegsa-fix-password-length-allowing-less…
stevegsa Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/javascript/packs/pw-strength.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ function getFeedback(z) {
return `${suggestions.map(s => lookup(s)).join('')}`;
}

function disableSubmit(submitEl, score = 0) {
function disableSubmit(submitEl, length = 0, score = 0) {
if (!submitEl) return;

if (score < 3) {
if (score < 3 || length < 12) {
submitEl.setAttribute('disabled', true);
} else {
submitEl.removeAttribute('disabled');
Expand Down Expand Up @@ -73,7 +73,7 @@ function analyzePw() {
pwStrength.innerHTML = strength;
pwFeedback.innerHTML = feedback;

disableSubmit(submit, z.score);
disableSubmit(submit, z.password.length, z.score);
}

if (/(msie 9)/i.test(userAgent)) {
Expand Down