Skip to content

Fix redirect when not presenting FIDO#2651

Merged
stevegsa merged 2 commits intomasterfrom
stevegsa-fix-webauthn-not-supported-redirect
Nov 9, 2018
Merged

Fix redirect when not presenting FIDO#2651
stevegsa merged 2 commits intomasterfrom
stevegsa-fix-webauthn-not-supported-redirect

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Nov 9, 2018

Why: The 2FA options list for login does not display FIDO when it is not supported. However the code bypasses the selection list and takes you to the preferred option that you have configured. A redirect was added to take the user back to the selection list but it was added to the setup js and not the authenticate js

How: In webauthn-authenticate.js, redirect to /login/two_factor/options when the user is on the webauthn login screen and FIDO is not supported.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

**Why**: The 2FA options list for login does not display FIDO when it is not supported.  However the code bypasses the selection list and takes you to the preferred option that you have configured.  A redirect was added to take the user back to the selection list but it was added to the setup js and not the authenticate js

**How**: In webauthn-authenticate.js, redirect to /login/two_factor/options when the user is on the webauthn login screen and FIDO is not supported.
@stevegsa
Copy link
Contributor Author

stevegsa commented Nov 9, 2018

See notes on #2642

@stevegsa
Copy link
Contributor Author

stevegsa commented Nov 9, 2018

Screenshots:

screen shot 2018-11-09 at 1 53 31 pm

On Chrome we go straight to the FIDO screen:
screen shot 2018-11-09 at 1 52 21 pm

On safari we wind up at the 2FA options and FIDO is not an option
screen shot 2018-11-09 at 1 53 08 pm
screen:

brodygov
brodygov previously approved these changes Nov 9, 2018
@stevegsa stevegsa merged commit a48dabb into master Nov 9, 2018
@brodygov brodygov deleted the stevegsa-fix-webauthn-not-supported-redirect branch November 9, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants