Skip to content

Add IAL and AAL columns to SP #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 2 commits into from
Oct 31, 2018
Merged

Add IAL and AAL columns to SP #2638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79d452
Add IAL and AAL columns to SP
jmhooper Oct 31, 2018
c9599f6
Merge branch 'master' into jmhooper-ial-all-migration
jmhooper Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions db/migrate/20181029203754_add_aal_and_ial_to_service_provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class AddAalAndIalToServiceProvider < ActiveRecord::Migration[5.1]
def change
add_column :service_providers, :aal, :integer
add_column :service_providers, :ial, :integer
Copy link
Copy Markdown
Contributor

@monfresh monfresh Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to be querying these columns? Do we need indexes?

end
end
4 changes: 3 additions & 1 deletion db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20181015153200) do
ActiveRecord::Schema.define(version: 20181029203754) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand Down Expand Up @@ -205,6 +205,8 @@
t.string "redirect_uris", default: [], array: true
t.integer "agency_id"
t.text "failure_to_proof_url"
t.integer "aal"
t.integer "ial"
t.index ["issuer"], name: "index_service_providers_on_issuer", unique: true
end

Expand Down