LG-726 Confirm before removing security key

[stevegsa]

Why: So the user can confirm they want to remove their security key or choose to cancel.

How: If their security key is their last 2FA option disable the delete link. If they have another 2FA option allow them to delete by first showing a modal. This modal will allow them to proceed or cancel and return to the account page.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

• When adding a new controller that requires the user to be fully
  authenticated, make sure to add before_action :confirm_two_factor_authenticated
  as the first callback.

Database

• Unsafe migrations are implemented over several PRs and over several
  deploys to avoid production errors. The strong_migrations gem
  will warn you about unsafe migrations and has great step-by-step instructions
  for various scenarios.

• Indexes were added if necessary. This article provides a good overview
  of indexes in Rails.

• Verified that the changes don't affect other apps (such as the dashboard)

• When relevant, a rake task is created to populate the necessary DB columns
  in the various environments right before deploying, taking into account the users
  who might not have interacted with this column yet (such as users who have not
  set a password yet)

• Migrations against existing tables have been tested against a copy of the
  production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
  issues. In that case, all the migration did was add a new column and an index to
  the Users table, which might seem innocuous.

Encryption

• The changes are compatible with data that was encrypted with the old code.

Routes

• GET requests are not vulnerable to CSRF attacks (i.e. they don't change
  state or result in destructive behavior).

Session

• When adding user data to the session, use the user_session helper
  instead of the session helper so the data does not persist beyond the user's
  session.

Testing

• Tests added for this feature/bug
• Prefer feature/integration specs over controller specs
• When adding code that reads data, write tests for nil values, empty strings,
  and invalid inputs.

[stevegsa]

Last 2FA option disables link to remove security key:

2 or more 2FA options enable link to remove security key:

Modal:

Key removed:

[clantosswett]

• I thought we weren't using the term "hardware security key" and were instead going with "security key"

• I don't really know the reasoning behind having the button say "remove" vs. "delete" since that is the language that is used throughout the whole process.

• Don't love having a single bullet point on the "Are you sure you want to delete your security key." Seems like that should just be formatted as a block of text. Also, we use the term "security key" on this page, hence the inconsistencies.

[rtwell]

[stevegsa]

Screenshots and verbiage revised. Please review.

[monfresh]

I'm testing this locally now, and after I add my first security key, I see a link that says "yes, remove key". Is that expected?

[stevegsa]

@monfresh great catch!

[stevegsa]

Screenshots have been updated again...

[rtwell]

any chance we can get a lil' more white space between the first button and the last sentence? see my comp for reference! thx!

[monfresh]

LGTM