Skip to content

LG-570 Update typography scale to match spec#2611

Merged
monfresh merged 1 commit intomasterfrom
gcasa-lg571-typography
Nov 7, 2018
Merged

LG-570 Update typography scale to match spec#2611
monfresh merged 1 commit intomasterfrom
gcasa-lg571-typography

Conversation

@gregory-casamento
Copy link
Contributor

@gregory-casamento gregory-casamento commented Oct 17, 2018

Why: The scale wasn't updated after the spec changed

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • The changes are compatible with data that was encrypted with the old code.

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • Tests added for this feature/bug

  • Prefer feature/integration specs over controller specs

  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the sass linter caught you here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed. It was due to the 1.0 instead of 1. The linter wanted it to have no mantissa. This is corrected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready for merge, pending a review.

@monfresh
Copy link
Contributor

monfresh commented Nov 1, 2018

@gregory-casamento Could you please update the commit message so that the summary is on the first line, and the why and how are below? Also, could you please fix the SASS lint issue: https://codeclimate.com/github/18F/identity-idp/pull/2611 ?

@monfresh monfresh changed the title LG-570 **How** Change css to reflect new spacing. **Why** Per instructions from Clare in LG-570 typography spacing was not correct. LG-570 Fix typography spacing on mobile Nov 4, 2018
**Why**: The scale wasn't updated after the spec changed
@monfresh monfresh force-pushed the gcasa-lg571-typography branch from 1a676a6 to 635e98b Compare November 7, 2018 19:17
@monfresh monfresh changed the title LG-570 Fix typography spacing on mobile LG-570 Update typography scale to match spec Nov 7, 2018
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh merged commit 74dbee0 into master Nov 7, 2018
@monfresh monfresh deleted the gcasa-lg571-typography branch November 7, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants