Skip to content

LG507: Remove PIV/CAC feature flag#2535

Merged
monfresh merged 1 commit intomasterfrom
gcasa-lg507-piv_cac_enabled-remove
Sep 22, 2018
Merged

LG507: Remove PIV/CAC feature flag#2535
monfresh merged 1 commit intomasterfrom
gcasa-lg507-piv_cac_enabled-remove

Conversation

@gregory-casamento
Copy link
Contributor

@gregory-casamento gregory-casamento commented Sep 20, 2018

Why: The PIV/CAC feature will not be disabled going forward, so we
are removing code that checks whether or not it is enabled.

How: I am searching through the code and removing all references to
the FeatureManagement.piv_cac_enabled? class method where appropriate.
I am also removing any tests or changing tests as needed.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@monfresh
Copy link
Contributor

I love PRs that remove code. Could you please update the commit message such that the **Why** section is in the body and not part of the first line? Thanks!

@gregory-casamento
Copy link
Contributor Author

I love PRs that remove code. Could you please update the commit message such that the **Why** section is in the body and not part of the first line? Thanks!

Done.

monfresh
monfresh previously approved these changes Sep 21, 2018
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh changed the title LG507: Remove piv_cac_enabled flag from FeatureManagment **Why**: Th… LG507: Remove piv_cac_enabled flag from FeatureManagment Sep 21, 2018
@monfresh monfresh force-pushed the gcasa-lg507-piv_cac_enabled-remove branch from 423ee3b to f8a754b Compare September 22, 2018 00:45
@monfresh monfresh changed the title LG507: Remove piv_cac_enabled flag from FeatureManagment LG507: Remove PIV/CAC feature flag Sep 22, 2018
@monfresh monfresh force-pushed the gcasa-lg507-piv_cac_enabled-remove branch 2 times, most recently from 7e4c66a to bd897cd Compare September 22, 2018 01:22
**Why**: The PIV/CAC feature will not be disabled going forward, so we
are removing code that checks whether or not it is enabled.

**How**: I am searching through the code and removing all references to
the FeatureManagement.piv_cac_enabled? class method where appropriate.
I am also removing any tests or changing tests as needed.
@monfresh monfresh force-pushed the gcasa-lg507-piv_cac_enabled-remove branch from bd897cd to 6038e6a Compare September 22, 2018 01:26
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh merged commit 6632c7a into master Sep 22, 2018
@monfresh monfresh deleted the gcasa-lg507-piv_cac_enabled-remove branch September 22, 2018 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants