Skip to content

Return blank for nil phone numbers #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgsmith-usds merged 1 commit into from
Sep 13, 2018
Merged

Return blank for nil phone numbers #2521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/decorators/user_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def delete_account_bullet_key
attr_reader :user

def masked_number(number)
return '' if number.blank?
"***-***-#{number[-4..-1]}"
end

Expand Down
8 changes: 8 additions & 0 deletions spec/decorators/user_decorator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@
end
end

describe '#masked_number' do
it 'returns blank for a nil number' do
user = build_stubbed(:user)
user_decorator = UserDecorator.new(user)
expect(user_decorator.send(:masked_number, nil)).to eq ''
end
end

describe '#active_identity_for' do
it 'returns Identity matching ServiceProvider' do
sp = create(:service_provider, issuer: 'http://sp.example.com')
Expand Down