Skip to content

LG-442 Remove unused sidekiq and worker code#2517

Merged
monfresh merged 1 commit intomasterfrom
mb-lg-442
Sep 17, 2018
Merged

LG-442 Remove unused sidekiq and worker code#2517
monfresh merged 1 commit intomasterfrom
mb-lg-442

Conversation

@monfresh
Copy link
Contributor

@monfresh monfresh commented Sep 12, 2018

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • The changes are compatible with data that was encrypted with the old code.

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • Tests added for this feature/bug

  • Prefer feature/integration specs over controller specs

  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@jmhooper
Copy link
Contributor

Are the worker healthcheck endpoints we removed here still being checked by New Relic?

@monfresh
Copy link
Contributor Author

Not sure. Where would I find out?

@jmhooper
Copy link
Contributor

I think we can check NR synthetics or ask in the devops channel?

@monfresh
Copy link
Contributor Author

I only see the top-level api/health in Synthetics.

jmhooper
jmhooper previously approved these changes Sep 13, 2018
@monfresh monfresh merged commit ea39aef into master Sep 17, 2018
@monfresh monfresh deleted the mb-lg-442 branch September 17, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants