Skip to content

Update redirect URI for sp-oidc-sinatra app#2509

Merged
monfresh merged 1 commit intomasterfrom
mb-update-redirect-uri
Sep 12, 2018
Merged

Update redirect URI for sp-oidc-sinatra app#2509
monfresh merged 1 commit intomasterfrom
mb-update-redirect-uri

Conversation

@monfresh
Copy link
Copy Markdown
Contributor

Why: We now require exact matches, and the config didn't have the
exact redirect URI

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • The changes are compatible with data that was encrypted with the old code.

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • Tests added for this feature/bug

  • Prefer feature/integration specs over controller specs

  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

stevegsa
stevegsa previously approved these changes Sep 12, 2018
Copy link
Copy Markdown
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

**Why**: We now require exact matches, and the config didn't have the
exact redirect URI
@monfresh monfresh force-pushed the mb-update-redirect-uri branch from 81cd382 to 4138a1f Compare September 12, 2018 16:12
@monfresh monfresh merged commit 12cb9cb into master Sep 12, 2018
@monfresh monfresh deleted the mb-update-redirect-uri branch September 12, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants