Skip to content

LG-641 Handle nil request_id properly #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monfresh merged 1 commit into from
Sep 10, 2018
Merged

LG-641 Handle nil request_id properly #2504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/users/sessions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def user_locked_out?(user)
end

def store_sp_metadata_in_session
return if sp_session[:issuer] || request_id.empty?
return if sp_session[:issuer] || request_id.blank?
StoreSpMetadataInSession.new(session: session, request_id: request_id).call
end

Expand Down
6 changes: 6 additions & 0 deletions spec/requests/invalid_sign_in_params_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@
get new_user_session_path, params: { user: 'test@test.com' }
end
end

context 'when the request_id param is present but with a nil value' do
it 'does not raise an error' do
get new_user_session_path, params: { request_id: nil }
end
end