LG-557 Update LOA3 "failure to proof" screens

[stevegsa]

Why: To provide a path forward for the user to complete their action in the event remote proofing failed

How: Implement the new design in the failure partials and create a new partial specifically for returning to the failure_to_proof_url supplied by the SP.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

• When adding a new controller that requires the user to be fully
  authenticated, make sure to add before_action :confirm_two_factor_authenticated
  as the first callback.

Database

• Unsafe migrations are implemented over several PRs and over several
  deploys to avoid production errors. The strong_migrations gem
  will warn you about unsafe migrations and has great step-by-step instructions
  for various scenarios.

• Indexes were added if necessary. This article provides a good overview
  of indexes in Rails.

• Verified that the changes don't affect other apps (such as the dashboard)

• When relevant, a rake task is created to populate the necessary DB columns
  in the various environments right before deploying, taking into account the users
  who might not have interacted with this column yet (such as users who have not
  set a password yet)

• Migrations against existing tables have been tested against a copy of the
  production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
  issues. In that case, all the migration did was add a new column and an index to
  the Users table, which might seem innocuous.

Encryption

• The changes are compatible with data that was encrypted with the old code.

Routes

• GET requests are not vulnerable to CSRF attacks (i.e. they don't change
  state or result in destructive behavior).

Session

• When adding user data to the session, use the user_session helper
  instead of the session helper so the data does not persist beyond the user's
  session.

Testing

• Tests added for this feature/bug
• Prefer feature/integration specs over controller specs
• When adding code that reads data, write tests for nil values, empty strings,
  and invalid inputs.

[stevegsa]

Screenshots:

desktop:

mobile:

desktop:

mobile:

desktop:

[jmhooper]

It looks like there is a template error that occurs when the sp name is nil per CI

[jmhooper]

You could probably use a content tag helper in the presenter to avoid have to call raw here.

[jmhooper]

Also, we had an offline discussion about a conditional to check that sp_name and failure_to_proof_url are both present before rendering. That could probably got outside the partial here.

[jmhooper]

Also, Get help at should be moved into a translation. That should mean you are able to do this:

t('path.to.translation_html', sp_name: decorated_session.sp_name)`

And then you translation would have the strong tags in it and they shouldn't be escaped since the translation is prefixed postfixed with html.

[jmhooper]

Here is an example of this in our code:

The translation: https://github.com/18F/identity-idp/blob/master/config/locales/devise/en.yml#L123

Where it is used in the presenter: https://github.com/18F/identity-idp/blob/master/app/presenters/two_factor_auth_code/max_attempts_reached_presenter.rb#L47-L51

[jmhooper]

Beautiful 🌅

[jmhooper]

I think the please_try_again link here is the clock which is what is giving you this failure.

[jmhooper]

We should probably go ahead and clean up these methods since they're dead code, right?

[jmhooper]

Looks like we missed these. I just amended the commit to catch them. I'm watching CI and will approve once that goes green.