Skip to content

Refactor and fix account reset requests#2444

Merged
monfresh merged 1 commit intomasterfrom
mb-account-reset-create-refactor
Aug 21, 2018
Merged

Refactor and fix account reset requests#2444
monfresh merged 1 commit intomasterfrom
mb-account-reset-create-refactor

Conversation

@monfresh
Copy link
Contributor

@monfresh monfresh commented Aug 21, 2018

Why:

  • We value lean controllers with minimal business logic
  • To fix a bug where users without a phone would see a message that an
    SMS was sent to their phone
  • To fix a bug where users who had not yet set up 2FA were redirected to
    the phone setup page instead of the 2FA setup page
  • To fix the French translation for the SMS message
  • To capture analytics about what kind of 2FA options the user has
    configured, to see if phone users request account deletion more than
    TOTP users, for example.
  • To capture analytics for visiting the account deletion page

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

**Why**:
- We value lean controllers with minimal business logic
- To fix a bug where users without a phone would see a message that an
SMS was sent to their phone
- To fix a bug where users who had not yet set up 2FA were redirected to
the phone setup page instead of the 2FA setup page
- To fix the French translation for the SMS message
- To capture analytics about what kind of 2FA options the user has
configured, to see if phone users request account deletion more than
TOTP users, for example.
- To capture analytics for visiting the account deletion page
@monfresh monfresh force-pushed the mb-account-reset-create-refactor branch from 9b0876f to bc63c29 Compare August 21, 2018 15:00
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh merged commit be1ef71 into master Aug 21, 2018
@monfresh monfresh deleted the mb-account-reset-create-refactor branch August 21, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants